Skip to content

fix(new-trace): Updating mongo db span description format.#79738

Merged
Abdkhan14 merged 1 commit into
masterfrom
abdk/trace-mongo-db-description
Oct 25, 2024
Merged

fix(new-trace): Updating mongo db span description format.#79738
Abdkhan14 merged 1 commit into
masterfrom
abdk/trace-mongo-db-description

Conversation

@Abdkhan14

Copy link
Copy Markdown
Contributor

Before:
Screenshot 2024-10-24 at 6 23 58 PM

After:
Screenshot 2024-10-24 at 6 24 27 PM

@Abdkhan14 Abdkhan14 requested a review from 0Calories October 24, 2024 22:24
@Abdkhan14 Abdkhan14 marked this pull request as ready for review October 24, 2024 22:24
@Abdkhan14 Abdkhan14 requested a review from a team October 24, 2024 22:24
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024

@0Calories 0Calories left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good short term fix, but it would be best if we could pretty print the JSON here rather than text-wrap, similar to the query summary page:
image

We can truncate via ClippedBox component so that the query doesn't take up too much space

@Abdkhan14 Abdkhan14 merged commit 9cbf811 into master Oct 25, 2024
@Abdkhan14 Abdkhan14 deleted the abdk/trace-mongo-db-description branch October 25, 2024 15:50
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants