Skip to content

Conversation

@gggritso
Copy link
Member

@gggritso gggritso commented Nov 6, 2024

Related to #61999. For organizations who are getting timeouts while fetching organization tags, use a ClickHouse SAMPLE N instead of a sampling rate.

The intent is to give this a try, and then roll out to everyone if it works out well. I'm going with 1,000,000 as a starting point, I'll be tweaking that number soon when I run some experiments.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 6, 2024
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sentry/tagstore/snuba/backend.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80332      +/-   ##
==========================================
- Coverage   78.31%   78.31%   -0.01%     
==========================================
  Files        7192     7192              
  Lines      318363   318369       +6     
  Branches    43885    43886       +1     
==========================================
+ Hits       249337   249339       +2     
- Misses      62670    62671       +1     
- Partials     6356     6359       +3     

@gggritso gggritso marked this pull request as ready for review November 6, 2024 22:04
@gggritso gggritso requested a review from a team as a code owner November 6, 2024 22:04
@gggritso gggritso requested a review from a team November 6, 2024 22:05
@gggritso gggritso merged commit 28dd891 into master Nov 8, 2024
49 of 50 checks passed
@gggritso gggritso deleted the feat/visibility/tag-key-sample-n branch November 8, 2024 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants