chore(login-banners): Remove banner choice from html #80426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
roggenkemper
changed the title
elijames-codecov
approved these changes
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #80426 +/- ##
==========================================
- Coverage 78.34% 78.33% -0.02%
==========================================
Files 7204 7204
Lines 318617 318616 -1
Branches 43914 43914
==========================================
- Hits 249616 249579 -37
- Misses 62648 62671 +23
- Partials 6353 6366 +13 |
roggenkemper
added a commit
that referenced
this pull request
Nov 8, 2024
since we are only showing 1 banner we don't need to randomly decide which one gets shown anymore. merge after #80426
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to only use one banner for now, so we can remove banner choice. A separate PR will remove
banner_choicefrom the context