Skip to content

chore(login-banners): Remove banner choice from backend #80427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore(login-banners): Remove banner choice from backend #80427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/sentry/web/frontend/auth_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

import logging
from random import randint
from typing import Any

from django.conf import settings
Expand Down Expand Up @@ -536,7 +535,6 @@ def get_default_context(self, request: Request, **kwargs) -> dict:
organization=organization, request=request
), # NOTE: not utilized in basic login page (only org login)
"show_login_banner": settings.SHOW_LOGIN_BANNER,
"banner_choice": randint(0, 1), # 2 possible banners
"referrer": request.GET.get("referrer"),
}
default_context.update(additional_context.run_callbacks(request=request))
Expand Down Expand Up @@ -715,7 +713,6 @@ def handle_basic_auth(self, request: Request, **kwargs) -> HttpResponseBase:
organization=organization, request=request
),
"show_login_banner": settings.SHOW_LOGIN_BANNER,
"banner_choice": randint(0, 1), # 2 possible banners
"referrer": request.GET.get("referrer"),
}

Expand Down
Loading