feat(issues): Combine regression issue details layouts #80433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the two performance issue layouts into the main layout. Our goal is to have fewer layouts specific to issue types and turn on and off components based on the issue's properties. config changes: - rename "tags" to "tagsTab" - new "tags" that disables highlights and tags - add spanEvidence option that can be disabled for these - add performanceDurationRegression and profilingDurationRegression which are kinda gross but right now they seem very specific together
github-actions
bot
added
the
Scope: Frontend
roggenkemper
reviewed
Nov 7, 2024
| ); | ||
| } | ||
| } | ||
| return hasStreamlinedUI ? ( |
roggenkemper
approved these changes
Nov 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80433 +/- ##
=======================================
Coverage 78.33% 78.33%
=======================================
Files 7204 7204
Lines 318616 318600 -16
Branches 43914 43912 -2
=======================================
- Hits 249589 249584 -5
+ Misses 62665 62654 -11
Partials 6362 6362 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the components from the two performance issue layouts into the main layout. Our goal is to have fewer custom layouts and turn on and off components based on the issue's properties.
config changes:
example issues:
performance duration regression - https://sentry.sentry.io/issues/5954692777/
profiling duration regression - https://sentry.sentry.io/issues/6023271097/