Skip to content

fix(project-details): Correct some types, don't crash on alert render fail#80466

Merged
leeandher merged 2 commits into
masterfrom
leander/fix-JAVASCRIPT-2WME
Nov 18, 2024
Merged

fix(project-details): Correct some types, don't crash on alert render fail#80466
leeandher merged 2 commits into
masterfrom
leander/fix-JAVASCRIPT-2WME

Conversation

@leeandher

Copy link
Copy Markdown
Member

Resolves JAVASCRIPT-2WME

@leeandher leeandher requested review from a team as code owners November 8, 2024 18:18
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 8, 2024
Comment on lines +67 to +69
eventProcessing?: {
symbolicationDegraded?: boolean;
};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does look like it might always be there https://github.com/getsentry/sentry/blob/master/src/sentry/api/serializers/models/project.py#L1024-L1026

i wonder if the project was missing entirely from the store

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's related to this - https://sentry.sentry.io/issues/5593998622/?project=11276. We might be loading something malformed into the projects store and causing these downstream errors

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the missing toSorted was an old browser thing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp nvm

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe when the project is created we use a different serializer?

@leeandher

Copy link
Copy Markdown
Member Author

Gonna merge since a bad type can be corrected but using an unusual serializer crashes the page.

@leeandher leeandher merged commit 7182034 into master Nov 18, 2024
@leeandher leeandher deleted the leander/fix-JAVASCRIPT-2WME branch November 18, 2024 16:10
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants