-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(nav): add analytics tracking #80512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
requested changes
Nov 12, 2024
saponifi3d
approved these changes
Nov 20, 2024
Contributor
saponifi3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - but @JonasBa will need to take another look to ✅
f44ab39 to
d46b4b9
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80512 +/- ##
===========================================
+ Coverage 57.52% 78.47% +20.95%
===========================================
Files 7204 7214 +10
Lines 319348 319652 +304
Branches 44005 44023 +18
===========================================
+ Hits 183696 250843 +67147
+ Misses 130893 62430 -68463
- Partials 4759 6379 +1620 |
JonasBa
approved these changes
Nov 21, 2024
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
trackAnalyticscall for primary nav items on the new sidebar