Skip to content

Conversation

@natemoo-re
Copy link
Member

Adds trackAnalytics call for primary nav items on the new sidebar

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 9, 2024
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but @JonasBa will need to take another look to ✅

@saponifi3d saponifi3d requested a review from JonasBa November 20, 2024 17:34
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/components/nav/sidebar.tsx 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #80512       +/-   ##
===========================================
+ Coverage   57.52%   78.47%   +20.95%     
===========================================
  Files        7204     7214       +10     
  Lines      319348   319652      +304     
  Branches    44005    44023       +18     
===========================================
+ Hits       183696   250843    +67147     
+ Misses     130893    62430    -68463     
- Partials     4759     6379     +1620     

@natemoo-re natemoo-re enabled auto-merge (squash) November 21, 2024 17:24
@natemoo-re natemoo-re merged commit 3ccad9e into master Nov 21, 2024
44 checks passed
@natemoo-re natemoo-re deleted the feat/nav-analytics branch November 21, 2024 17:38
iamrajjoshi pushed a commit that referenced this pull request Nov 24, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
evanh pushed a commit that referenced this pull request Nov 25, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
Adds `trackAnalytics` call for primary nav items on the new sidebar
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants