Merged
Conversation
Member
wmak
commented
Nov 12, 2024
wmak
commented
- Rates used to depend on a hack at the endpoint level where interval was passed as an argument for generating charts, this updates all the rate functions to just grab interval from the builder
- This also fixes a bug where equations on rates wouldn't work since the rate function wouldn't have the rate passed in since its hidden inside an equation
- Rates used to depend on a hack at the endpoint level where interval was passed as an argument for generating charts, this updates all the rate functions to just grab interval from the builder - This also fixes a bug where equations on rates wouldn't work since the rate function wouldn't have the rate passed in since its hidden inside an equation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80617 +/- ##
===========================================
+ Coverage 51.35% 78.36% +27.00%
===========================================
Files 7176 7208 +32
Lines 317343 318790 +1447
Branches 43732 43920 +188
===========================================
+ Hits 162979 249822 +86843
+ Misses 153242 62605 -90637
- Partials 1122 6363 +5241 |
Zylphrex
approved these changes
Nov 13, 2024
| interval = args["interval"] | ||
| return Function( | ||
| "divide", | ||
| [Function("count", []), Function("divide", [interval, 60])], |
Member
There was a problem hiding this comment.
Nit: Cant you divide interval by 60 here before passing it through?
Member
Author
There was a problem hiding this comment.
ah shoot missed this, i'll follow up
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
wmak
added a commit
that referenced
this pull request
Nov 15, 2024
- Accidentally deleted this in #80617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.