Skip to content

feat(ai): New GenAI Consent Flow #80717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2024
Merged

feat(ai): New GenAI Consent Flow #80717

merged 4 commits into from
Nov 15, 2024

Conversation

@jennmueng
Copy link
Member

@jennmueng jennmueng commented Nov 14, 2024 •
edited
Loading

New consent flow within the drawer allowing you to consent right there.

CleanShot 2024-11-13 at 16 18 44@2x

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
8227 2 8225 0
View the top 2 failed tests by shortest run time 
AutofixDrawer triggers autofix on clicking the Start button
Stack Traces | 0.061s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Start Autofix"

Here are the accessible roles:

  banner:

  Name "":
  ...

  --------------------------------------------------
  button:

  Name "Close Drawer":
  ...

  --------------------------------------------------
  navigation:

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  --------------------------------------------------
  heading:

  Name "Solutions Hub":
  ...

  --------------------------------------------------
  complementary:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../issueDetails/streamline/solutionsHubDrawer.spec.tsx:110:53)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
AutofixDrawer renders properly
Stack Traces | 0.086s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Start Autofix"

Here are the accessible roles:

  banner:

  Name "":
  ...

  --------------------------------------------------
  button:

  Name "Close Drawer":
  ...

  --------------------------------------------------
  navigation:

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  --------------------------------------------------
  heading:

  Name "Solutions Hub":
  ...

  --------------------------------------------------
  complementary:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../issueDetails/streamline/solutionsHubDrawer.spec.tsx:83:53)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@jennmueng jennmueng mentioned this pull request Nov 14, 2024
Merged
@jennmueng jennmueng requested a review from roaga November 14, 2024 19:40
@jennmueng jennmueng marked this pull request as ready for review November 14, 2024 19:40
@jennmueng jennmueng requested review from a team as code owners November 14, 2024 19:40
roaga
roaga approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennmueng jennmueng mentioned this pull request Nov 14, 2024
Merged
@jennmueng jennmueng merged commit bd1b6bf into master Nov 15, 2024
43 checks passed
@jennmueng jennmueng deleted the jenn/ai-consent branch November 15, 2024 18:28
jennmueng added a commit that referenced this pull request Nov 15, 2024
@jennmueng
chore(ai-consent): Use a new gen_ai_consent_v2024_11_14 (#80755)
855e9ab 
Uses a new gen ai consent option which will be defined in
getsentry/getsentry#15719

Needs to go in after getsentry/getsentry#15719
but before getsentry/getsentry#15714 and
#80717
jennmueng added a commit that referenced this pull request Nov 15, 2024
@jennmueng @scttcper
feat(autofix): Check specific autofix enabled option (#80785)
1a042e7 
Should be merged after #80717 to avoid conflicts.

Before, the autofix setup steps will disappear once the required steps
are completed. Now we check for a specific option that autofix is
enabled. This way the steps don't disappear until you enable it.

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roaga roaga roaga approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jennmueng @roaga