Skip to content

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Nov 14, 2024

It removes the feature flag from #80655.

We GAed this morning. I will wait a bit before removing this code.

Removes the feature flag from #80655
@armenzg armenzg added the Do Not Merge Don't merge label Nov 14, 2024
@armenzg armenzg self-assigned this Nov 14, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 14, 2024
assert response.data["statusDetails"] == {}

@with_feature("organizations:releases-resolve-next-release-semver-fix")
def test_resolved_in_next_release_with_flag_no_release(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was to prevent normal releases from regressing with the new fix.

This is the test it duplicated:

def test_resolved_in_next_release_no_release(self):
self.login_as(user=self.user)
project = self.create_project()
project.flags.has_releases = True
project.save()
event = self.store_event(data={}, project_id=project.id)
group = event.group
assert group is not None
url = f"/api/0/organizations/{group.organization.slug}/issues/{group.id}/"
response = self.client.put(url, data={"status": "resolvedInNextRelease"})
assert response.status_code == 200, response.content
# Refetch from DB to ensure the latest state is fetched
group = Group.objects.get(id=group.id, project=group.project.id)
assert group.status == GroupStatus.RESOLVED
# no GroupResolution because there is no release
assert not GroupResolution.objects.filter(group=group).exists()
assert response.data["statusDetails"] == {}

@armenzg armenzg marked this pull request as ready for review December 2, 2024 15:36
@armenzg armenzg requested a review from a team as a code owner December 2, 2024 15:36
@armenzg armenzg merged commit d5f3e34 into master Dec 4, 2024
48 checks passed
@armenzg armenzg deleted the remove_feature_flag/issue_69937/armenzg branch December 4, 2024 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Component: Releases Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants