ref(replay): Change Logcat and Timber frames to console frames #80777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Nov 14, 2024
billyvg
reviewed
Nov 14, 2024
Comment on lines
28
to
31
| // Logcat and Timber are considered a console frame instead of a custom breadcrumb frame | ||
| if (frame.category === 'Logcat' || frame.category === 'Timber') { | ||
| frame.category = 'console'; | ||
| } |
Member
There was a problem hiding this comment.
I'd be careful of doing this as we would be mutating the original frame... if we wanted to preserve the original frame, we could instead move the logic down to the return value. that way we can avoid any mutations to the original frame object.
billyvg
approved these changes
Nov 14, 2024
| } | ||
| return { | ||
| ...frame, | ||
| // Logcat and Timber are considered a console frame instead of a custom breadcrumb frame |
Member
There was a problem hiding this comment.
maybe note that this is for mobile replays
c298lee
commented
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mobile replays, we use Logcat and Timber as loggers, so we want them to show up in the console tab instead of the breadcrumbs tab.
Before:
After:
