Skip to content

ref(replay): Change Logcat and Timber frames to console frames #80777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

ref(replay): Change Logcat and Timber frames to console frames #80777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7641e
consider Logcat and Timber as console frames
c298lee Nov 14, 2024
33930ab
don't mutate original frame
c298lee Nov 14, 2024
9c5ea14
Update static/app/utils/replays/hydrateBreadcrumbs.tsx
c298lee Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/app/utils/replays/hydrateBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,12 @@ export default function hydrateBreadcrumbs(
}
return {
...frame,
// Logcat and Timber are used for mobile replays and are considered a console frame instead of a custom breadcrumb frame
// custom frames might not have a defined category, so we need to set one
category: frame.category || defaultTitle(frame) || 'custom',
category:
frame.category === 'Logcat' || frame.category === 'Timber'
? 'console'
: frame.category || defaultTitle(frame) || 'custom',
offsetMs: Math.abs(time.getTime() - startTimestampMs),
timestamp: time,
timestampMs: time.getTime(),
Expand Down
3 changes: 2 additions & 1 deletion static/app/utils/replays/replayReader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import {
getNodeIds,
IncrementalSource,
isCLSFrame,
isConsoleFrame,
isDeadClick,
isDeadRageClick,
isPaintFrame,
Expand Down Expand Up @@ -507,7 +508,7 @@ export default class ReplayReader {
getErrorFrames = () => this._errors;

getConsoleFrames = memoize(() =>
this._sortedBreadcrumbFrames.filter(frame => frame.category === 'console')
this._sortedBreadcrumbFrames.filter(frame => isConsoleFrame(frame))
);

getNavigationFrames = memoize(() =>
Expand Down
8 changes: 6 additions & 2 deletions static/app/views/replays/detail/console/useConsoleFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import type {SelectOption} from 'sentry/components/compactSelect';
import {defined} from 'sentry/utils';
import {decodeList, decodeScalar} from 'sentry/utils/queryString';
import useFiltersInLocationQuery from 'sentry/utils/replays/hooks/useFiltersInLocationQuery';
import type {BreadcrumbFrame, ConsoleFrame} from 'sentry/utils/replays/types';
import {
type BreadcrumbFrame,
type ConsoleFrame,
isConsoleFrame,
} from 'sentry/utils/replays/types';
import {filterItems} from 'sentry/views/replays/detail/utils';

export interface ConsoleSelectOption extends SelectOption<string> {
Expand All @@ -32,7 +36,7 @@ type Return = {
};

function getFilterableField(frame: BreadcrumbFrame) {
if (frame.category === 'console') {
if (isConsoleFrame(frame)) {
const consoleFrame = frame as ConsoleFrame;
return consoleFrame.level;
}
Expand Down
Loading