feat(rpc): enable extrapolation by default#80829
Conversation
- This enables extrapolation by default for the rpc queries - This fixes a bug where the events endpoint wasn't actually returning the result... also rexfails a bunch of the tests
github-actions
Bot
added
the
Scope: Backend
| @dataclass(frozen=True) | ||
| class ResolvedColumn(ResolvedAttribute): | ||
| # The internal rpc alias for this column | ||
| internal_name: str = "" |
There was a problem hiding this comment.
Is this default required for some reason? Can't you leave it unspecified and it'll be a required arg when initializing an instance?
There was a problem hiding this comment.
Hmmm good point, my original thinking was that if its not set "" is better than error, but found kw_only for dataclass, because otherwise ResolvedColumn gets mad that internal_name follows default args
| @dataclass(frozen=True) | ||
| class ResolvedFunction(ResolvedAttribute): | ||
| # The internal rpc alias for this column | ||
| internal_name: Function.ValueType = Function.FUNCTION_UNSPECIFIED |
There was a problem hiding this comment.
Same thing here regarding the default value.
|
|
||
| @property | ||
| def proto_type(self) -> AttributeKey.Type.ValueType: | ||
| """The rpc always returns functions as floats""" |
There was a problem hiding this comment.
Would be good to clarify that this is the case even for count()
| "count()": 2, | ||
| "count(span.duration)": 2, | ||
| "count(tags[foo, number])": 1, | ||
| "count(tags[foo, number])": 2, |
There was a problem hiding this comment.
This looks wrong. Only 1 of the spans have a numeric attribute named foo. Why did it change to 2?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80829 +/- ##
===========================================
+ Coverage 57.78% 78.42% +20.63%
===========================================
Files 6941 7211 +270
Lines 304363 319756 +15393
Branches 41979 44012 +2033
===========================================
+ Hits 175873 250765 +74892
+ Misses 123995 62603 -61392
- Partials 4495 6388 +1893 |
- xfail test
un xfail test
wmak
changed the title
2 participants
the result... also re-xfails a bunch of the tests