fix(rpc): Define measurements columns for RPC#80866
Merged
Merged
Conversation
We need to ensure that in the RPC layer, we still correctly handle the sentry defined measurements.
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80866 +/- ##
===========================================
+ Coverage 57.51% 78.43% +20.91%
===========================================
Files 7200 7211 +11
Lines 319181 319817 +636
Branches 43946 44026 +80
===========================================
+ Hits 183580 250845 +67265
+ Misses 130845 62581 -68264
- Partials 4756 6391 +1635 |
…efine-measurements-columns-for-rpc
wmak
approved these changes
Nov 18, 2024
Comment on lines
+416
to
+418
| if resolved.search_type != "string" or not isinstance( | ||
| resolved.proto_definition, AttributeKey | ||
| ): |
Member
There was a problem hiding this comment.
heads up this change; https://github.com/getsentry/sentry/pull/80829/files#diff-ca53615e4a5d771b967f49cd366caf62d188212ece593a146cf4b31de578015aR67-R79
will mean we don't need to do the isinstance part of the check anymore
| simple_measurements_field("messaging.message.body.size"), | ||
| simple_measurements_field("messaging.message.receive.latency"), | ||
| simple_measurements_field("messaging.message.retry.count"), | ||
| simple_measurements_field("http.response_content_length"), |
…efine-measurements-columns-for-rpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to ensure that in the RPC layer, we still correctly handle the sentry defined measurements.