Skip to content

chore(grouping): Differentiate fingerprint and enhancements class names#80872

Merged
lobsterkatie merged 5 commits into
masterfrom
kmclb-differentiate-fingerprint-and-enhancement-rule-class-names
Nov 18, 2024
Merged

chore(grouping): Differentiate fingerprint and enhancements class names#80872
lobsterkatie merged 5 commits into
masterfrom
kmclb-differentiate-fingerprint-and-enhancement-rule-class-names

Conversation

@lobsterkatie

Copy link
Copy Markdown
Member

Both fingerprinting rules and stacktrace rules ("enhancements") use classes called Rule and Match, and without spending time figuring out the context, it's hard to tell which of them one is dealing with. This therefore changes the names all four classes (along with the enhancements Action class, just to keep things standardized) to include Fingerprint or Enhancement as appropriate. No behavior changes, just a lot of find and replace.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2024
@codecov

codecov Bot commented Nov 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/grouping/enhancer/matchers.py 77.77% 2 Missing ⚠️
src/sentry/grouping/enhancer/rules.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80872   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files        7211     7211           
  Lines      319805   319805           
  Branches    44027    44027           
=======================================
  Hits       250832   250832           
- Misses      62579    62580    +1     
+ Partials     6394     6393    -1     

@lobsterkatie lobsterkatie marked this pull request as ready for review November 15, 2024 23:52
@lobsterkatie lobsterkatie requested a review from a team as a code owner November 15, 2024 23:52

@snigdhas snigdhas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

Base automatically changed from kmclb-store-hashing-metadata to master November 18, 2024 17:29
@lobsterkatie lobsterkatie force-pushed the kmclb-differentiate-fingerprint-and-enhancement-rule-class-names branch from 48b63cf to 205b414 Compare November 18, 2024 17:33
@lobsterkatie lobsterkatie merged commit ed00c05 into master Nov 18, 2024
@lobsterkatie lobsterkatie deleted the kmclb-differentiate-fingerprint-and-enhancement-rule-class-names branch November 18, 2024 18:15
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants