chore(grouping): Differentiate fingerprint and enhancements class names#80872
Merged
lobsterkatie merged 5 commits intoNov 18, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80872 +/- ##
=======================================
Coverage 78.43% 78.43%
=======================================
Files 7211 7211
Lines 319805 319805
Branches 44027 44027
=======================================
Hits 250832 250832
- Misses 62579 62580 +1
+ Partials 6394 6393 -1 |
48b63cf to
205b414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both fingerprinting rules and stacktrace rules ("enhancements") use classes called
RuleandMatch, and without spending time figuring out the context, it's hard to tell which of them one is dealing with. This therefore changes the names all four classes (along with the enhancementsActionclass, just to keep things standardized) to includeFingerprintorEnhancementas appropriate. No behavior changes, just a lot of find and replace.