Skip to content

Conversation

@michellewzhang
Copy link
Member

onboarding docs changed which caused a bug with the platform option dropdown showing an extra "with"

before:
SCR-20241118-lqgb
SCR-20241118-lqhb
after:
SCR-20241118-lqer
SCR-20241118-lqfg

@michellewzhang michellewzhang requested a review from a team November 18, 2024 20:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nents/replaysOnboarding/platformOptionDropdown.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80938   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files        7209     7209           
  Lines      319622   319590   -32     
  Branches    44006    43997    -9     
=======================================
- Hits       250642   250628   -14     
+ Misses      62594    62576   -18     
  Partials     6386     6386           

@michellewzhang michellewzhang merged commit c447b31 into master Nov 18, 2024
43 of 44 checks passed
@michellewzhang michellewzhang deleted the mz/fix-replay-platform-options branch November 18, 2024 21:25
michellewzhang added a commit that referenced this pull request Nov 21, 2024
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
evanh pushed a commit that referenced this pull request Nov 25, 2024
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants