feat(ai): Migrate ai features to use new consolidated flag#80948
Conversation
github-actions
Bot
added
the
Scope: Backend
| if not ( | ||
| features.has("projects:ai-autofix", group.project) | ||
| or features.has("organizations:autofix", group.organization) | ||
| or group.organization.get_option("sentry:gen_ai_consent_v2024_11_14", False) |
There was a problem hiding this comment.
this should've been an and for the genai consent this whole time
There was a problem hiding this comment.
No, we made this an or for the Copilot extension as a workaround to allow GitHub to give access to whoever without us having to flag them in.
There was a problem hiding this comment.
I see, but now is it ok as we're open beta-ing this or should we revert it to an or?
There was a problem hiding this comment.
Offline decision: it's okay to remove this
| "disable_codebase_indexing": features.has( | ||
| "organizations:autofix-disable-codebase-indexing", |
There was a problem hiding this comment.
are we removing these flags elsewhere in another PR?
There was a problem hiding this comment.
yes following up with a flag removal pr
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80948 +/- ##
==========================================
- Coverage 78.48% 78.47% -0.02%
==========================================
Files 7210 7207 -3
Lines 319532 319455 -77
Branches 43963 43957 -6
==========================================
- Hits 250797 250701 -96
- Misses 62348 62364 +16
- Partials 6387 6390 +3 |
roaga
left a comment
roaga
left a comment
There was a problem hiding this comment.
Do we need to improve test coverage with all these changes?
|
@roaga yeah means the lines we change weren't covered |
2 participants
Consolidate all the AI features to use the same flag. Also removes unused instances of the codebase indexing endpoints.
To ensure consistency for customers flagged by this, this must be merged after https://github.com/getsentry/sentry-options-automator/pull/2700