Skip to content

test(kafka-test): adds a simple test for task worker integrations #80958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

test(kafka-test): adds a simple test for task worker integrations #80958

wants to merge 7 commits into from

Conversation

@john-z-yang
Copy link
Contributor

@john-z-yang john-z-yang commented Nov 18, 2024 •
edited
Loading

Adds an integration test for taskbroker. Using sentry as a working repository to figure out dependencies

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 18, 2024
@john-z-yang john-z-yang force-pushed the john/taskworker-integrations branch from 4ba6006 to 3954412 Compare November 19, 2024 00:17
@john-z-yang john-z-yang force-pushed the john/taskworker-integrations branch from 258f620 to e750e60 Compare November 21, 2024 02:15
markstory
markstory reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general direction this is going. I think this might be better positioned in the taskbroker repository though as it will be less relevant to changes in sentry and more relevant to changes in taskbroker.

We should still have a stub task in sentry for doing these integration tests though, and should also reuse sentry's devservices to get kafka started.

@john-z-yang
Copy link
Contributor Author

john-z-yang commented Nov 21, 2024

I like the general direction this is going. I think this might be better positioned in the taskbroker repository though as it will be less relevant to changes in sentry and more relevant to changes in taskbroker.

We should still have a stub task in sentry for doing these integration tests though, and should also reuse sentry's devservices to get kafka started.

Yeah I agree, we want to get things working before splitting it off first, so we're just using this PR to collaborate

@john-z-yang
Copy link
Contributor Author

john-z-yang commented Dec 3, 2024

This is merged via
getsentry/taskbroker#53

@john-z-yang john-z-yang closed this Dec 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markstory markstory markstory left review comments

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@john-z-yang @markstory @enochtangg