-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(explore): Use processed autocomplete names #81008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The processed autocomplete names will map things lcp to `measurements.lcp` so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.
wmak
approved these changes
Nov 19, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81008 +/- ##
=======================================
Coverage 71.03% 71.03%
=======================================
Files 7212 7212
Lines 319629 319638 +9
Branches 44038 44038
=======================================
+ Hits 227057 227065 +8
- Misses 85478 85479 +1
Partials 7094 7094 |
Bundle ReportChanges will increase total bundle size by 30.7kB (0.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
…use-processed-autocomplete-names
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
The processed autocomplete names will map things lcp to `measurements.lcp` so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
The processed autocomplete names will map things lcp to `measurements.lcp` so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
The processed autocomplete names will map things lcp to `measurements.lcp` so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
The processed autocomplete names will map things lcp to `measurements.lcp` so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processed autocomplete names will map things lcp to
measurements.lcpso we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.