Skip to content

Conversation

@Zylphrex
Copy link
Member

The processed autocomplete names will map things lcp to measurements.lcp so we show them the way they used to be shown in other parts of sentry. Additionally, we'll get units back by doing this.

The processed autocomplete names will map things lcp to `measurements.lcp` so we
show them the way they used to be shown in other parts of sentry. Additionally,
we'll get units back by doing this.
@Zylphrex Zylphrex requested a review from a team as a code owner November 19, 2024 21:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 19, 2024
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tic/app/views/explore/contexts/spanTagsContext.tsx 66.66% 4 Missing ⚠️
static/app/views/explore/tables/fieldRenderer.tsx 83.33% 2 Missing ⚠️
static/app/views/explore/charts/index.tsx 0.00% 1 Missing ⚠️
...tatic/app/views/explore/tables/aggregatesTable.tsx 0.00% 1 Missing ⚠️
...ws/performance/utils/useSpanFieldSupportedTags.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81008   +/-   ##
=======================================
  Coverage   71.03%   71.03%           
=======================================
  Files        7212     7212           
  Lines      319629   319638    +9     
  Branches    44038    44038           
=======================================
+ Hits       227057   227065    +8     
- Misses      85478    85479    +1     
  Partials     7094     7094           

@Zylphrex Zylphrex requested review from a team November 21, 2024 16:16
@codecov
Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 30.7kB (0.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.97MB 30.7kB (0.1%) ⬆️

@Zylphrex Zylphrex requested a review from a team November 21, 2024 16:48
@Zylphrex Zylphrex merged commit cf7a490 into master Nov 21, 2024
43 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/use-processed-autocomplete-names branch November 21, 2024 17:10
iamrajjoshi pushed a commit that referenced this pull request Nov 24, 2024
The processed autocomplete names will map things lcp to
`measurements.lcp` so we show them the way they used to be shown in
other parts of sentry. Additionally, we'll get units back by doing this.
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
The processed autocomplete names will map things lcp to
`measurements.lcp` so we show them the way they used to be shown in
other parts of sentry. Additionally, we'll get units back by doing this.
evanh pushed a commit that referenced this pull request Nov 25, 2024
The processed autocomplete names will map things lcp to
`measurements.lcp` so we show them the way they used to be shown in
other parts of sentry. Additionally, we'll get units back by doing this.
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
The processed autocomplete names will map things lcp to
`measurements.lcp` so we show them the way they used to be shown in
other parts of sentry. Additionally, we'll get units back by doing this.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants