Skip to content

Conversation

@snigdhas
Copy link
Contributor

Switching to a simple serializer for the grouphash endpoint. This endpoint is used to load the merged-issues page on an issue and doesn't need to gather all the extra info (stacktrace, packages, tags, etc) about all events in order to populate the page.

Fixes #80961

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 19, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2024
@snigdhas snigdhas force-pushed the snigdha/add-fields-to-serializer branch from 9508fae to 434f980 Compare November 20, 2024 00:32
@getsentry getsentry deleted a comment from github-actions bot Nov 20, 2024
@snigdhas snigdhas removed the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2024
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@snigdhas snigdhas marked this pull request as ready for review November 20, 2024 19:20
@snigdhas snigdhas requested review from a team as code owners November 20, 2024 19:20
@snigdhas snigdhas removed the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2024
snigdhas added a commit that referenced this pull request Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81017      +/-   ##
==========================================
- Coverage   78.28%   75.07%   -3.22%     
==========================================
  Files        7215     7208       -7     
  Lines      319794   319485     -309     
  Branches    44034    43974      -60     
==========================================
- Hits       250359   239855   -10504     
- Misses      63038    73096   +10058     
- Partials     6397     6534     +137     

@snigdhas snigdhas merged commit d9e4aa5 into master Nov 21, 2024
48 of 49 checks passed
@snigdhas snigdhas deleted the snigdha/add-fields-to-serializer branch November 21, 2024 17:51
iamrajjoshi pushed a commit that referenced this pull request Nov 24, 2024
#81017)

Switching to a simple serializer for the grouphash endpoint. This
endpoint is used to load the merged-issues page on an issue and doesn't
need to gather all the extra info (stacktrace, packages, tags, etc)
about all events in order to populate the page.

Fixes #80961
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
#81017)

Switching to a simple serializer for the grouphash endpoint. This
endpoint is used to load the merged-issues page on an issue and doesn't
need to gather all the extra info (stacktrace, packages, tags, etc)
about all events in order to populate the page.

Fixes #80961
evanh pushed a commit that referenced this pull request Nov 25, 2024
evanh pushed a commit that referenced this pull request Nov 25, 2024
#81017)

Switching to a simple serializer for the grouphash endpoint. This
endpoint is used to load the merged-issues page on an issue and doesn't
need to gather all the extra info (stacktrace, packages, tags, etc)
about all events in order to populate the page.

Fixes #80961
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
#81017)

Switching to a simple serializer for the grouphash endpoint. This
endpoint is used to load the merged-issues page on an issue and doesn't
need to gather all the extra info (stacktrace, packages, tags, etc)
about all events in order to populate the page.

Fixes #80961
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

“Unable to load merged events” error when on Merge Issues tab of Issue Detail page

3 participants