feat: use signed-urls for email confirmation#81044
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
mdtro
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81044 +/- ##
===========================================
+ Coverage 50.28% 87.58% +37.30%
===========================================
Files 9371 9460 +89
Lines 535758 537011 +1253
Branches 21113 21113
===========================================
+ Hits 269409 470361 +200952
+ Misses 265991 66292 -199699
Partials 358 358 |
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
from
6f57577 to
1d69f1c
Compare
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
2 times, most recently
from
55a7098 to
0e855fe
Compare
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
from
0e855fe to
08edfea
Compare
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
from
08edfea to
8df6ab9
Compare
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
from
576f0a7 to
468f99d
Compare
sentaur-athena
requested review from
cathteng,
leedongwei and
sentaur-athena
cathteng
reviewed
Dec 12, 2024
cathteng
left a comment
cathteng
left a comment
Contributor
There was a problem hiding this comment.
i think this will work on the backend but i'm curious what the user experience will be like
mdtro
commented
Dec 16, 2024
mdtro
commented
Dec 16, 2024
mdtro
force-pushed
the
mdtro/signed-urls-email-confirm
branch
from
151261a to
d359430
Compare
sentaur-athena
approved these changes
Jan 10, 2025
cathteng
approved these changes
Jan 10, 2025
mdtro
added a commit
that referenced
this pull request
Jan 10, 2025
Frontend changes to support #81044 Here's what it will look like in the frontend after submitting the form with a new email: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/6f06e89b-a1d2-40eb-a4a4-1e860e07d57d" /> If you submit it with one that's already on your account: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/57daad3f-e129-4176-ba9a-fc36c73b11ea" />
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
We currently allow secondary emails to be added to accounts without verification. This leads to subtle bugs, some with security implications. This PR adds an option to transition use to signed URLs to add secondary emails on accounts. Instead of adding the email address immediately to the account in an unverified state, a signed URL is generated and emailed to the email address. The secondary email is not added to the account. Once clicked, the signed URL is verified and if valid, the secondary email is added to the user's account as a verified address. Here's what it will look like in the frontend after submitting the form with a new email: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/6f06e89b-a1d2-40eb-a4a4-1e860e07d57d" /> If you submit it with one that's already on your account: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/57daad3f-e129-4176-ba9a-fc36c73b11ea" /> Frontend PR will follow. The option that gates this functionality will not be enabled until the frontend PR is deployed.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Frontend changes to support #81044 Here's what it will look like in the frontend after submitting the form with a new email: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/6f06e89b-a1d2-40eb-a4a4-1e860e07d57d" /> If you submit it with one that's already on your account: <img width="1280" alt="image" src="https://github.com/user-attachments/assets/57daad3f-e129-4176-ba9a-fc36c73b11ea" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently allow secondary emails to be added to accounts without verification. This leads to subtle bugs, some with security implications.
This PR adds an option to transition use to signed URLs to add secondary emails on accounts. Instead of adding the email address immediately to the account in an unverified state, a signed URL is generated and emailed to the email address. The secondary email is not added to the account.
Once clicked, the signed URL is verified and if valid, the secondary email is added to the user's account as a verified address.
Here's what it will look like in the frontend after submitting the form with a new email:
If you submit it with one that's already on your account:
Frontend PR will follow. The option that gates this functionality will not be enabled until the frontend PR is deployed.