feat(dashboards): Add to Dashboard from Explore #81064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81064 +/- ##
===========================================
+ Coverage 64.79% 78.48% +13.68%
===========================================
Files 7211 7215 +4
Lines 319619 319663 +44
Branches 44034 44019 -15
===========================================
+ Hits 207102 250883 +43781
+ Misses 105804 62405 -43399
+ Partials 6713 6375 -338 |
This modal is coupled strongly with discover saved queries. Moving this up to a param so I could integrate it properly with Explore
narsaynorath
force-pushed
the
nar/feat/dashboards-eap-add-to-dashboard
branch
from
fa60561 to
37a98be
Compare
narsaynorath
changed the base branch from
master
to
nar/ref/dashboards-add-to-dashboard-move-dataset-change-to-caller
narsaynorath
changed the title
Base automatically changed from
nar/ref/dashboards-add-to-dashboard-move-dataset-change-to-caller
to
master
November 21, 2024 14:41
edwardgou-sentry
approved these changes
Nov 21, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
narsaynorath
added
the
Trigger: Revert
Contributor
|
PR reverted: 2849ca8 |
getsentry-bot
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit 9fb8494. Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>
narsaynorath
added a commit
that referenced
this pull request
Nov 21, 2024
Same as #81064 but with tests fixed.
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
Adds a button to the chart in explore so we can click "Add to Dashboard" and use Explore as a jump off point for a dashboard widget. The button has the following functionality: - Takes the first 3 series from the chart and opens up the add to dashboard modal - The filter should transfer over - When switching to table view, the table in dashboards gets filled with the columns from the samples table if added from sample mode - When added from aggregate mode, the table view gets the group bys followed by the aggregates Note: The group by doesn't currently get filled in for timeseries charts. I will follow up with another PR to make group by work.
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
This reverts commit 9fb8494. Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
Same as #81064 but with tests fixed.
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
Adds a button to the chart in explore so we can click "Add to Dashboard" and use Explore as a jump off point for a dashboard widget. The button has the following functionality: - Takes the first 3 series from the chart and opens up the add to dashboard modal - The filter should transfer over - When switching to table view, the table in dashboards gets filled with the columns from the samples table if added from sample mode - When added from aggregate mode, the table view gets the group bys followed by the aggregates Note: The group by doesn't currently get filled in for timeseries charts. I will follow up with another PR to make group by work.
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
This reverts commit 9fb8494. Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
Same as #81064 but with tests fixed.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
Adds a button to the chart in explore so we can click "Add to Dashboard" and use Explore as a jump off point for a dashboard widget. The button has the following functionality: - Takes the first 3 series from the chart and opens up the add to dashboard modal - The filter should transfer over - When switching to table view, the table in dashboards gets filled with the columns from the samples table if added from sample mode - When added from aggregate mode, the table view gets the group bys followed by the aggregates Note: The group by doesn't currently get filled in for timeseries charts. I will follow up with another PR to make group by work.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
This reverts commit 9fb8494. Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
Same as #81064 but with tests fixed.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Adds a button to the chart in explore so we can click "Add to Dashboard" and use Explore as a jump off point for a dashboard widget. The button has the following functionality: - Takes the first 3 series from the chart and opens up the add to dashboard modal - The filter should transfer over - When switching to table view, the table in dashboards gets filled with the columns from the samples table if added from sample mode - When added from aggregate mode, the table view gets the group bys followed by the aggregates Note: The group by doesn't currently get filled in for timeseries charts. I will follow up with another PR to make group by work.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
This reverts commit 9fb8494. Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Same as #81064 but with tests fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a button to the chart in explore so we can click "Add to Dashboard" and use Explore as a jump off point for a dashboard widget.
The button has the following functionality: