-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(autofix): Split out code mappings into a separate setup step #81083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this sparks joy |
roaga
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's:
- Remove the unnecessary text in both steps, because the button does a lot of work for us
- Test the link in prod
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81083 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 7215 7215
Lines 319793 319835 +42
Branches 44034 44048 +14
=======================================
+ Hits 250996 251032 +36
- Misses 62404 62410 +6
Partials 6393 6393 |
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
…1083) Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page:   The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails. The configuration query is reverse engineered from: https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
…1083) Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page:   The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails. The configuration query is reverse engineered from: https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…1083) Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page:   The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails. The configuration query is reverse engineered from: https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page:


The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails.
The configuration query is reverse engineered from:
sentry/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx
Lines 42 to 66 in 99f305e