Skip to content

Conversation

@jennmueng
Copy link
Member

Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page:
CleanShot 2024-11-20 at 14 30 45@2x
CleanShot 2024-11-20 at 14 30 55@2x

The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails.

The configuration query is reverse engineered from:

type State = {
configurations: Integration[];
information: {providers: IntegrationProvider[]};
};
class IntegrationDetailedView extends AbstractIntegrationDetailedView<
AbstractIntegrationDetailedView['props'],
State & AbstractIntegrationDetailedView['state']
> {
tabs: Tab[] = ['overview', 'configurations', 'features'];
getEndpoints(): ReturnType<DeprecatedAsyncComponent['getEndpoints']> {
const {organization} = this.props;
const {integrationSlug} = this.props.params;
return [
[
'information',
`/organizations/${organization.slug}/config/integrations/?provider_key=${integrationSlug}`,
],
[
'configurations',
`/organizations/${organization.slug}/integrations/?provider_key=${integrationSlug}&includeConfig=0`,
],
];
}

@jennmueng jennmueng requested a review from a team as a code owner November 20, 2024 22:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2024
@trillville
Copy link
Contributor

this sparks joy

Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's:

  1. Remove the unnecessary text in both steps, because the button does a lot of work for us
  2. Test the link in prod

@trillville
Copy link
Contributor

CleanShot 2024-11-20 at 14 51 21@2x
should this copy be updated? Do you actually need to do what the text is saying or simply click the button (also do we need the hyperlink to the settings page in the text?)

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81083   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files        7215     7215           
  Lines      319793   319835   +42     
  Branches    44034    44048   +14     
=======================================
+ Hits       250996   251032   +36     
- Misses      62404    62410    +6     
  Partials     6393     6393           

@jennmueng jennmueng requested a review from a team as a code owner November 20, 2024 23:41
@jennmueng jennmueng merged commit 82dec67 into master Nov 20, 2024
44 checks passed
@jennmueng jennmueng deleted the jenn/autofix/improved-setup branch November 20, 2024 23:55
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
…1083)

Renders the guided steps UI again, but this time the code mappings is
its own step. To aid in reducing friction, there are now prominent
buttons that jump to the relevant settings page:
![CleanShot 2024-11-20 at 14 30
45@2x](https://github.com/user-attachments/assets/58a69a22-2335-43da-8cda-e211a288c058)
![CleanShot 2024-11-20 at 14 30
55@2x](https://github.com/user-attachments/assets/3fe962bd-1fa2-4775-b02d-a4c354732066)

The code mappings button will link directly to the code mappings setup
page, but as there isn't really a straightforward way for me to easily
test a github integration setup locally, I've added a fallback to just
linking to the github integration setup page as usual if that query
fails.

The configuration query is reverse engineered from:

https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
evanh pushed a commit that referenced this pull request Nov 25, 2024
…1083)

Renders the guided steps UI again, but this time the code mappings is
its own step. To aid in reducing friction, there are now prominent
buttons that jump to the relevant settings page:
![CleanShot 2024-11-20 at 14 30
45@2x](https://github.com/user-attachments/assets/58a69a22-2335-43da-8cda-e211a288c058)
![CleanShot 2024-11-20 at 14 30
55@2x](https://github.com/user-attachments/assets/3fe962bd-1fa2-4775-b02d-a4c354732066)

The code mappings button will link directly to the code mappings setup
page, but as there isn't really a straightforward way for me to easily
test a github integration setup locally, I've added a fallback to just
linking to the github integration setup page as usual if that query
fails.

The configuration query is reverse engineered from:

https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
…1083)

Renders the guided steps UI again, but this time the code mappings is
its own step. To aid in reducing friction, there are now prominent
buttons that jump to the relevant settings page:
![CleanShot 2024-11-20 at 14 30
45@2x](https://github.com/user-attachments/assets/58a69a22-2335-43da-8cda-e211a288c058)
![CleanShot 2024-11-20 at 14 30
55@2x](https://github.com/user-attachments/assets/3fe962bd-1fa2-4775-b02d-a4c354732066)

The code mappings button will link directly to the code mappings setup
page, but as there isn't really a straightforward way for me to easily
test a github integration setup locally, I've added a fallback to just
linking to the github integration setup page as usual if that query
fails.

The configuration query is reverse engineered from:

https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants