feat(autofix): Write access is optional in setup via query #81101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81101 +/- ##
==========================================
- Coverage 80.34% 80.34% -0.01%
==========================================
Files 7225 7225
Lines 320221 320224 +3
Branches 20781 20781
==========================================
+ Hits 257272 257274 +2
- Misses 62555 62556 +1
Partials 394 394 |
jennmueng
force-pushed
the
jenn/autofix/make-write-optional-be
branch
from
e22b0d2 to
d9ccfb9
Compare
roaga
approved these changes
Nov 21, 2024
Member
roaga
left a comment
roaga
left a comment
There was a problem hiding this comment.
An extra test for check_write_access=false would be good, otherwise LGTM
| group = self.create_group() | ||
| self.login_as(user=self.user) | ||
| url = f"/api/0/issues/{group.id}/autofix/setup/" | ||
| url = f"/api/0/issues/{group.id}/autofix/setup/?check_write_access=true" |
Member
There was a problem hiding this comment.
Should we also have a test where check_write_access = false?
Member
Author
There was a problem hiding this comment.
already tested for the empty condition at test_successful_setup which is equivalent to false
jennmueng
force-pushed
the
jenn/autofix/make-write-optional-be
branch
from
d9ccfb9 to
d3c2f35
Compare
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
Only call seer for the write access check for when Autofix is ready to create a PR
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
Only call seer for the write access check for when Autofix is ready to create a PR
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Only call seer for the write access check for when Autofix is ready to create a PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only call seer for the write access check for when Autofix is ready to create a PR