Skip to content

feat(stories): Add RouteAnalyticsContextProvider to stories so we can see what is viewed #81108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(stories): Add RouteAnalyticsContextProvider to stories so we can see what is viewed #81108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 36 additions & 33 deletions static/app/views/stories/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {space} from 'sentry/styles/space';
import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
import {useHotkeys} from 'sentry/utils/useHotkeys';
import OrganizationContainer from 'sentry/views/organizationContainer';
import RouteAnalyticsContextProvider from 'sentry/views/routeAnalyticsContextProvider';
import EmptyStory from 'sentry/views/stories/emptyStory';
import ErrorStory from 'sentry/views/stories/errorStory';
import storiesContext from 'sentry/views/stories/storiesContext';
Expand All @@ -25,40 +26,42 @@ export default function Stories({location}: Props) {
useHotkeys([{match: '/', callback: () => searchInput.current?.focus()}], []);

return (
<OrganizationContainer>
<Layout>
<StoryHeader style={{gridArea: 'head'}} />

<Sidebar style={{gridArea: 'aside'}}>
<Input
ref={searchInput}
placeholder="Search files by name"
onChange={e => setSearchTerm(e.target.value.toLowerCase())}
/>
<TreeContainer>
<StoryTree
files={storiesContext()
.files()
.filter(s => s.toLowerCase().includes(searchTerm))}
<RouteAnalyticsContextProvider>
<OrganizationContainer>
<Layout>
<StoryHeader style={{gridArea: 'head'}} />

<Sidebar style={{gridArea: 'aside'}}>
<Input
ref={searchInput}
placeholder="Search files by name"
onChange={e => setSearchTerm(e.target.value.toLowerCase())}
/>
</TreeContainer>
</Sidebar>

{story.error ? (
<VerticalScroll style={{gridArea: 'body'}}>
<ErrorStory error={story.error} />
</VerticalScroll>
) : story.resolved ? (
<Main style={{gridArea: 'body'}}>
<StoryFile filename={story.filename} resolved={story.resolved} />
</Main>
) : (
<VerticalScroll style={{gridArea: 'body'}}>
<EmptyStory />
</VerticalScroll>
)}
</Layout>
</OrganizationContainer>
<TreeContainer>
<StoryTree
files={storiesContext()
.files()
.filter(s => s.toLowerCase().includes(searchTerm))}
/>
</TreeContainer>
</Sidebar>

{story.error ? (
<VerticalScroll style={{gridArea: 'body'}}>
<ErrorStory error={story.error} />
</VerticalScroll>
) : story.resolved ? (
<Main style={{gridArea: 'body'}}>
<StoryFile filename={story.filename} resolved={story.resolved} />
</Main>
) : (
<VerticalScroll style={{gridArea: 'body'}}>
<EmptyStory />
</VerticalScroll>
)}
</Layout>
</OrganizationContainer>
</RouteAnalyticsContextProvider>
);
}

Expand Down
Loading