Skip to content

Conversation

@phacops
Copy link
Contributor

@phacops phacops commented Nov 21, 2024

The metrics summaries are not needed anymore since we shut down DDM.

This will remove the query layer and endpoints used by the frontend to list samples associated with metrics.

https://github.com/getsentry/team-ingest/issues/544

@sentry
Copy link

sentry bot commented Nov 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/utils/snuba.py

Function Unhandled Issue
_apply_cache_and_build_results RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ConcurrentRateLimitAllo... ...
Event Count: 11
_apply_cache_and_build_results RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'BytesScannedRejectingPo... ...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/endpoints/organization_traces.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81133      +/-   ##
==========================================
- Coverage   80.33%   80.29%   -0.05%     
==========================================
  Files        7223     7219       -4     
  Lines      320112   319454     -658     
  Branches    20779    20779              
==========================================
- Hits       257174   256492     -682     
- Misses      62545    62569      +24     
  Partials      393      393              

@phacops phacops marked this pull request as ready for review November 22, 2024 17:33
@phacops phacops requested review from a team as code owners November 22, 2024 17:33
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@phacops phacops merged commit c1f0132 into master Nov 22, 2024
50 checks passed
@phacops phacops deleted the pierre/remove-metrics-summaries-queries branch November 22, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants