Skip to content

fix(issues): Add projectId for flag onboarding on click #81387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix(issues): Add projectId for flag onboarding on click #81387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ab06f
fix(issues): Add projectId for flag onboarding on click
scttcper Nov 27, 2024
a4b5027
no replace?
scttcper Nov 27, 2024
8cd0ec6
keep replace
scttcper Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions static/app/components/events/featureFlags/eventFeatureFlagList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import type {Project} from 'sentry/types/project';
import {trackAnalytics} from 'sentry/utils/analytics';
import {useFeedbackForm} from 'sentry/utils/useFeedbackForm';
import useOrganization from 'sentry/utils/useOrganization';
import useUrlParams from 'sentry/utils/useUrlParams';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {useIssueDetailsEventView} from 'sentry/views/issueDetails/streamline/hooks/useIssueDetailsDiscoverQuery';
import {useOrganizationFlagLog} from 'sentry/views/issueDetails/streamline/hooks/useOrganizationFlagLog';
Expand Down Expand Up @@ -78,11 +77,6 @@ export function EventFeatureFlagList({
},
});
const {activateSidebarSkipConfigure} = useFeatureFlagOnboarding();
const {setParamValue: setProjectId} = useUrlParams('project');

useEffect(() => {
setProjectId(event.projectID);
}, [setProjectId, event.projectID]);

const {
suspectFlags,
Expand Down Expand Up @@ -191,7 +185,9 @@ export function EventFeatureFlagList({
<Button
aria-label={t('Set Up Integration')}
size="xs"
onClick={activateSidebarSkipConfigure}
onClick={mouseEvent => {
activateSidebarSkipConfigure(mouseEvent, project.id);
}}
>
{t('Set Up Integration')}
</Button>
Expand Down
23 changes: 18 additions & 5 deletions static/app/components/events/featureFlags/useFeatureFlagOnboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {SidebarPanelKey} from 'sentry/components/sidebar/types';
import SidebarPanelStore from 'sentry/stores/sidebarPanelStore';
import {trackAnalytics} from 'sentry/utils/analytics';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';

const FLAG_HASH = '#flag-sidequest';
Expand All @@ -12,6 +13,7 @@ export const FLAG_HASH_SKIP_CONFIG = '#flag-sidequest-skip';
export function useFeatureFlagOnboarding() {
const location = useLocation();
const organization = useOrganization();
const navigate = useNavigate();

useEffect(() => {
if (location.hash === FLAG_HASH || location.hash === FLAG_HASH_SKIP_CONFIG) {
Expand All @@ -30,11 +32,22 @@ export function useFeatureFlagOnboarding() {

// if we detect that event.contexts.flags is set, use this hook instead
// to skip the configure step
const activateSidebarSkipConfigure = useCallback((event: React.MouseEvent) => {
event.preventDefault();
window.location.hash = FLAG_HASH_SKIP_CONFIG;
SidebarPanelStore.activatePanel(SidebarPanelKey.FEATURE_FLAG_ONBOARDING);
}, []);
const activateSidebarSkipConfigure = useCallback(
(event: React.MouseEvent, projectId: string) => {
event.preventDefault();
navigate(
{
pathname: location.pathname,
// Adding the projectId will help pick the correct project in onboarding
query: {...location.query, project: projectId},
hash: FLAG_HASH_SKIP_CONFIG,
},
{replace: true}
);
SidebarPanelStore.activatePanel(SidebarPanelKey.FEATURE_FLAG_ONBOARDING);
},
[navigate, location.pathname, location.query]
);

return {activateSidebar, activateSidebarSkipConfigure};
}
Loading