Skip to content

feat(taskbroker): Add the taskbroker to devservices#81968

Merged
evanh merged 4 commits into
masterfrom
evanh/feat/test-taskbroker-docker
Dec 17, 2024
Merged

feat(taskbroker): Add the taskbroker to devservices#81968
evanh merged 4 commits into
masterfrom
evanh/feat/test-taskbroker-docker

Conversation

@evanh
Copy link
Copy Markdown
Member

@evanh evanh commented Dec 11, 2024

Add the ability to start a local taskbroker instance, behind a flag. This image is updated every
time a PR is merged into taskbroker main.

Also added two small scripts to help with local testing.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 11, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #81968       +/-   ##
===========================================
+ Coverage   58.53%   80.36%   +21.82%     
===========================================
  Files        7267     7275        +8     
  Lines      320742   321171      +429     
  Branches    20958    20933       -25     
===========================================
+ Hits       187759   258107    +70348     
+ Misses     132569    62653    -69916     
+ Partials      414      411        -3     

Comment thread src/sentry/conf/server.py Outdated
Comment thread src/sentry/options/defaults.py Outdated
Comment thread bin/send_to_taskbroker.py Outdated
@evanh evanh requested review from a team as code owners December 17, 2024 18:28
@evanh evanh requested a review from a team December 17, 2024 18:28
@evanh evanh requested review from a team as code owners December 17, 2024 18:28
@evanh evanh requested a review from a team December 17, 2024 18:28
@evanh evanh requested review from a team as code owners December 17, 2024 18:28
@evanh evanh requested review from a team December 17, 2024 18:28
@evanh evanh requested review from a team as code owners December 17, 2024 18:28
Comment thread bin/get_pending_task.py Outdated
Comment thread bin/get_pending_task.py Outdated
Comment thread src/sentry/conf/server.py
Comment thread src/sentry/conf/server.py
Comment thread src/sentry/options/defaults.py Outdated
Comment thread bin/get_pending_task.py Outdated
Copy link
Copy Markdown
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes to prevent auto merge

Comment thread src/sentry/conf/server.py Outdated
Copy link
Copy Markdown
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanh evanh disabled auto-merge December 17, 2024 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants