fix(dashboards): Glitching bar charts on url changes#82457
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Dec 20, 2024
Member
|
Just wanted to add that I'm still seeing a flicker when I do stuff like type in the name field, we'll try to look at getting rid of that but this feels fine for us to do now to prevent the impact of the re-rendering |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
The glitching bar charts every time the url changes was annoying and it was happening due to the bar chart animations (where it rises from 0). I turned off the animations for dashboard bar charts. I've also snuck in a fix for the widget preview height on big number widgets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glitching bar charts every time the url changes was annoying and it was happening due to the bar chart animations (where it rises from 0). I turned off the animations for dashboard bar charts.
I've also snuck in a fix for the widget preview height on big number widgets.