chore(dashboards): Remove Edit Access feature flag references#83021
Merged
nikkikapadia merged 1 commit intomasterfrom Jan 8, 2025
Merged
chore(dashboards): Remove Edit Access feature flag references#83021nikkikapadia merged 1 commit intomasterfrom
nikkikapadia merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
commented
Jan 7, 2025
| await userEvent.keyboard('{Escape}'); | ||
|
|
||
| await userEvent.click(screen.getByText('Cancel')); | ||
| await userEvent.click(screen.getByTestId('filter-bar-cancel')); |
Member
Author
There was a problem hiding this comment.
I had to do this a bunch because the cancel button on the access selector was also getting picked up. This ensures it is the correct cancel button that we are testing for
narsaynorath
approved these changes
Jan 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Removes all instances of the edit access feature flag in the code base. Also had to make some test adjustments to handle this. Context: https://sentry.slack.com/archives/C01MYDW8Y7K/p1736203608171589 Next step: Removing the feature flag from the options repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all instances of the edit access feature flag in the code base. Also had to make some test adjustments to handle this.
Context: https://sentry.slack.com/archives/C01MYDW8Y7K/p1736203608171589
Next step: Removing the feature flag from the options repo.