🔧 chore(workflow engine): remove legacy_notification_type column#83100
Merged
iamrajjoshi merged 1 commit intomasterfrom Jan 8, 2025
Merged
🔧 chore(workflow engine): remove legacy_notification_type column#83100iamrajjoshi merged 1 commit intomasterfrom
iamrajjoshi merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Moved action.legacy_notification_type field to pending deletion state
--
-- (no-op) |
wedamija
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we will not be using this field anymore b/c with this design, we can't share actions between metric & issue alerts. instead, we will be saving configuration for both issue & metric alerts for the 7 common integrations between the two.
doc for more context