Skip to content

feat(flags): add first flag sent analytic#83217

Merged
michellewzhang merged 2 commits into
masterfrom
mz/add-flag-analytic
Jan 10, 2025
Merged

feat(flags): add first flag sent analytic#83217
michellewzhang merged 2 commits into
masterfrom
mz/add-flag-analytic

Conversation

@michellewzhang

@michellewzhang michellewzhang commented Jan 10, 2025

Copy link
Copy Markdown
Contributor
  • adds a first_flag_received signal
  • adds an analytics event first_flag.sent that updates the has_flags flag on the project. this is called when the post_process job senses that the event.contexts.flags is being sent for the first time for that project
  • closes https://github.com/getsentry/team-replay/issues/499

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 10, 2025
@codecov

This comment was marked as outdated.

@michellewzhang michellewzhang marked this pull request as ready for review January 10, 2025 19:04
@michellewzhang michellewzhang requested a review from a team as a code owner January 10, 2025 19:04
@michellewzhang michellewzhang requested review from a team, JoshFerge, aliu39 and cmanallen January 10, 2025 19:04

@aliu39 aliu39 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michellewzhang michellewzhang merged commit bd9e0e0 into master Jan 10, 2025
@michellewzhang michellewzhang deleted the mz/add-flag-analytic branch January 10, 2025 20:26
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
- adds a `first_flag_received` signal
- adds an analytics event `first_flag.sent` that updates the `has_flags`
flag on the project. this is called when the `post_process` job senses
that the `event.contexts.flags` is being sent for the first time for
that project
- closes getsentry/team-replay#499
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants