fix(consumer): Ensure backpressure is properly handled in stale message routing#83271
Merged
Conversation
…ge handling Previously we were not handling the case where a `MessageRejected` error which signals backpressure from downstream steps might be received in the dlq stale messages strategy. If this happens we can just ignore the error, we will retry on the next loop.
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83271 +/- ##
===========================================
+ Coverage 71.29% 87.55% +16.26%
===========================================
Files 9472 9477 +5
Lines 537229 537627 +398
Branches 21163 21163
===========================================
+ Hits 383001 470708 +87707
+ Misses 153870 66561 -87309
Partials 358 358 |
kneeyo1
approved these changes
Jan 11, 2025
mwarkentin
approved these changes
Jan 11, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ge routing (#83271) Previously we were not handling the case where a `MessageRejected` error which signals backpressure from downstream steps might be received in the dlq stale messages strategy. If this happens we can just ignore the error, we will retry on the next loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were not handling the case where a
MessageRejectederror which signals backpressure from downstream steps might be received in the dlq stale messages strategy. If this happens we can just ignore the error, we will retry on the next loop.