lint(eslint): Special case *.js config and script files in eslint #83286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
reviewed
Jan 11, 2025
Comment on lines
-1781
to
-1785
| if (position < top) { | ||
| position = position; | ||
| } else if (position > top + height) { | ||
| if (position > top + height) { | ||
| position = index * 24 - height + 24; | ||
| } else { |
Member
Author
There was a problem hiding this comment.
Yeah it's a weird diff.
It was complaining about the statement 'position = position' in the first IF block. So I removed that but then it was an empty block. So I refactored the conditions from if/elseif/else to be if/elseif. The first IF condition got inverted into the new elseif at the bottom.
scttcper
reviewed
Jan 13, 2025
scttcper
approved these changes
Jan 13, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.