feat(rpc): Add meta to the stats response#83538
Merged
Merged
Conversation
- Missed adding stats to the stats responses - TODO: need to update top_events after #83446 merges - Fixed a bug where count_unique was the wrong type
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83538 +/- ##
========================================
Coverage 87.55% 87.56%
========================================
Files 9543 9546 +3
Lines 541002 541254 +252
Branches 21290 21290
========================================
+ Hits 473679 473939 +260
+ Misses 66968 66960 -8
Partials 355 355 |
Zylphrex
reviewed
Jan 23, 2025
Zylphrex
left a comment
Zylphrex
left a comment
Member
There was a problem hiding this comment.
Mainly about the anomaly detection test but I'm pretty sure that feature has been removed.
Zylphrex
approved these changes
Jan 23, 2025
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
- Missed adding stats to the stats responses - Going to treat the rpc response as if transform alias is always on - TODO: need to update top_events after #83446 merges - Fixed a bug where count_unique was the wrong type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.