Skip to content

fix(tempest): Change error type#83580

Merged
tobias-wilfert merged 1 commit into
masterfrom
tobias-wilfert/fix/changed-error-type
Jan 16, 2025
Merged

fix(tempest): Change error type#83580
tobias-wilfert merged 1 commit into
masterfrom
tobias-wilfert/fix/changed-error-type

Conversation

@tobias-wilfert

Copy link
Copy Markdown
Member

Changed error type to be nicer after feedback from @vgrozdanic. This is done to now match the format that is returned by Tempest.

@tobias-wilfert tobias-wilfert requested a review from a team as a code owner January 16, 2025 15:15
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 16, 2025

@vgrozdanic vgrozdanic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vgrozdanic

Copy link
Copy Markdown
Member

It might be also good to introduce enum with all of the error types, then you don't have to hardcode the string in a multiple places

@tobias-wilfert tobias-wilfert enabled auto-merge (squash) January 16, 2025 15:28
@codecov

codecov Bot commented Jan 16, 2025

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23537 1 23536 276
View the full list of 1 ❄️ flaky tests
tests.sentry.api.endpoints.test_organization_events_trends_v2.OrganizationEventsTrendsStatsV2EndpointTest::test_two_projects_same_transaction_split_queries

Flake rate in main: 9.43% (Passed 48 times, Failed 5 times)

Stack Traces | 2.28s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_events_trends_v2.py#x1B[0m:414: in test_two_projects_same_transaction_split_queries
    assert len(trends_call_args_data_1[f"{project1.id},foo bar*"]) > 0
#x1B[1m#x1B[31mE   KeyError: '4555395139895300,foo bar*'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@tobias-wilfert tobias-wilfert merged commit 3eae35d into master Jan 16, 2025
@tobias-wilfert tobias-wilfert deleted the tobias-wilfert/fix/changed-error-type branch January 16, 2025 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants