lint(eslint): Enable array-type rule & auto-fix violations#83804
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Jan 22, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
ryan953
added a commit
that referenced
this pull request
Jan 23, 2025
…ion (#83927) This was suggested in slack and I really like the [`array-simple`](https://typescript-eslint.io/rules/array-type/#array-simple) variation over the default [`array`](https://typescript-eslint.io/rules/array-type/#array) that we enabled [yesterday](#83804). TL/DR the `array-simple` variation will prefer `MyType[]` when `MyType` is a simple, or named type. If there's anything more complex in that spot, like a union or unnamed object type then we'll see `Array<...>` instead. This means in practice we wont' see round braces near our complex array definitions; less syntax for my eyes to parse.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
…ion (#83927) This was suggested in slack and I really like the [`array-simple`](https://typescript-eslint.io/rules/array-type/#array-simple) variation over the default [`array`](https://typescript-eslint.io/rules/array-type/#array) that we enabled [yesterday](#83804). TL/DR the `array-simple` variation will prefer `MyType[]` when `MyType` is a simple, or named type. If there's anything more complex in that spot, like a union or unnamed object type then we'll see `Array<...>` instead. This means in practice we wont' see round braces near our complex array definitions; less syntax for my eyes to parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.