✨ feat(aci): create issue alert migration helper for azure devops#83806
Merged
iamrajjoshi merged 1 commit intoJan 28, 2025
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
reviewed
Jan 22, 2025
| assert len(actions) == 0 | ||
|
|
||
| def test_azure_devops_migration(self): | ||
| action_data = [ |
Contributor
There was a problem hiding this comment.
#Todo for a future date -- it'd be a nice to have to have a self.create_notification_action or something along those lines to help create these
saponifi3d
approved these changes
Jan 22, 2025
| """TicketDataBlob is a specific type that represents the data blob for a ticket creation action.""" | ||
|
|
||
| # This is dynamic and can whatever customer config the customer setup on GitHub | ||
| dynamic_form_fields: list[dict] = field(default_factory=list) |
Contributor
There was a problem hiding this comment.
nit: it might be nice to have stricter typing on list[dict] like what is the dict? TicketData?
Collaborator
Author
There was a problem hiding this comment.
will be part of a followup pr. i made the ticket here: https://getsentry.atlassian.net/browse/ACI-119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue alert migration helper for azure devops, similar to github and github enterprise
branched off of #83793, will merge after this one is merged
closes https://getsentry.atlassian.net/browse/ACI-102