Skip to content

Conversation

@c298lee
Copy link
Contributor

@c298lee c298lee commented Jan 27, 2025

In preparation for upgrading to Sentry SDK v9, we need to remove _browserPerformanceTimeOriginMode as it's deprecated.

@c298lee c298lee requested review from billyvg, chargome and wmak January 27, 2025 22:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 27, 2025
import type {MeasurementUnit, Span, TransactionEvent} from '@sentry/core';
import * as Sentry from '@sentry/react';
import {
_browserPerformanceTimeOriginMode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh the underscore makes the linter ignore it even though it was unused

@c298lee c298lee merged commit 48b4fb9 into master Jan 28, 2025
43 checks passed
@c298lee c298lee deleted the cl/rm-browserperformancetimeoriginmode branch January 28, 2025 20:05
andrewshie-sentry pushed a commit that referenced this pull request Jan 29, 2025
In preparation for upgrading to Sentry SDK v9, we need to remove
`_browserPerformanceTimeOriginMode` as it's deprecated.
c298lee added a commit that referenced this pull request Jan 29, 2025
In preparation for upgrading to Sentry SDK v9, we need to remove
`_browserPerformanceTimeOriginMode` as it's deprecated.
c298lee added a commit that referenced this pull request Feb 3, 2025
Related PRs for updating some deprecations:
- #84130
- #84132
- #84196
- #84254

PR for updating getsentry:
https://github.com/getsentry/getsentry/pull/16292
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
Related PRs for updating some deprecations:
- #84130
- #84132
- #84196
- #84254

PR for updating getsentry:
getsentry/getsentry#16292
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants