Skip to content

chore: Remove _browserPerformanceTimeOriginMode #84132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore: Remove _browserPerformanceTimeOriginMode #84132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions static/app/bootstrap/initializeSdk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// eslint-disable-next-line simple-import-sort/imports
import * as Sentry from '@sentry/react';
import {type Event, _browserPerformanceTimeOriginMode} from '@sentry/core';
import type {Event} from '@sentry/core';

import {SENTRY_RELEASE_VERSION, SPA_DSN} from 'sentry/constants';
import type {Config} from 'sentry/types/system';
Expand Down Expand Up @@ -234,7 +234,6 @@ export function initializeSdk(config: Config) {
// Track timeOrigin Selection by the SDK to see if it improves transaction durations
Sentry.addEventProcessor((event: Sentry.Event, _hint?: Sentry.EventHint) => {
event.tags = event.tags || {};
event.tags['timeOrigin.mode'] = _browserPerformanceTimeOriginMode;
return event;
});

Expand Down
6 changes: 1 addition & 5 deletions static/app/utils/performanceForSentry/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import type {ProfilerOnRenderCallback, ReactNode} from 'react';
import {Fragment, Profiler, useEffect, useRef} from 'react';
import type {MeasurementUnit, Span, TransactionEvent} from '@sentry/core';
import * as Sentry from '@sentry/react';
import {
_browserPerformanceTimeOriginMode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh the underscore makes the linter ignore it even though it was unused

browserPerformanceTimeOrigin,
timestampInSeconds,
} from '@sentry/utils';
import {browserPerformanceTimeOrigin, timestampInSeconds} from '@sentry/utils';

import {useLocation} from 'sentry/utils/useLocation';
import usePrevious from 'sentry/utils/usePrevious';
Expand Down
Loading