Skip to content

test(widget-builder): Remove circular dependency in analytics#84289

Merged
narsaynorath merged 1 commit into
masterfrom
nar/test/widget-builder-fix-circular-dependencies-in-visualize
Jan 30, 2025
Merged

test(widget-builder): Remove circular dependency in analytics#84289
narsaynorath merged 1 commit into
masterfrom
nar/test/widget-builder-fix-circular-dependencies-in-visualize

Conversation

@narsaynorath

Copy link
Copy Markdown
Member

Analytics was importing this type, which came from a file that imported analytics. Move the type into its own file to resolve some of these conflicts.

Analytics was importing this type, which came from a file that imported
analytics. Move the type into its own file to resolve some of these
conflicts.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 30, 2025
@narsaynorath narsaynorath marked this pull request as ready for review January 30, 2025 15:21
@narsaynorath narsaynorath requested review from a team and nikkikapadia and removed request for a team January 30, 2025 15:21

@nikkikapadia nikkikapadia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@narsaynorath narsaynorath merged commit 5170a7c into master Jan 30, 2025
@narsaynorath narsaynorath deleted the nar/test/widget-builder-fix-circular-dependencies-in-visualize branch January 30, 2025 15:35
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
Analytics was importing this type, which came from a file that imported
analytics. Move the type into its own file to resolve some of these
conflicts.
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants