fix(issue-views): Make page filters a parameter in mutate request #84381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Jan 31, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
…4381) fixes SENTRY-3MZS (hopefully) This PR updates the useMemo in the debounce function that updates Issue Views to not recreate itself upon page filter changes. Instead, it takes those page filters as parameters. We were seeing cases where the request was being sent in very rapid succession (<200ms apart) despite the debouncing, so one explanation might be that the denounced function is being recreated too frequently, thus "resetting" the timer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes SENTRY-3MZS
(hopefully)
This PR updates the useMemo in the debounce function that updates Issue Views to not recreate itself upon page filter changes. Instead, it takes those page filters as parameters.
We were seeing cases where the request was being sent in very rapid succession (<200ms apart) despite the debouncing, so one explanation might be that the denounced function is being recreated too frequently, thus "resetting" the timer.