Skip to content

rename to pipeline_views for clarity #8480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MeredithAnya merged 2 commits into from
May 30, 2018
Merged

rename to pipeline_views for clarity #8480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ee6a7
rename to pipeline_views for clarity
MeredithAnya May 17, 2018
4614688
Merge branch 'master' into rename-pipline-views
MeredithAnya May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sentry/pipeline/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,13 @@ def __init__(self, request, organization, provider_key, provider_model=None, con
self.provider.set_pipeline(self)
self.provider.set_config(config)

self.pipeline = self.get_pipeline_views()
self.pipeline_views = self.get_pipeline_views()

# we serialize the pipeline to be ['fqn.PipelineView', ...] which
# allows us to determine if the pipeline has changed during the auth
# flow or if the user is somehow circumventing a chunk of it
pipe_ids = ['{}.{}'.format(type(v).__module__, type(v).__name__)
for v in self.pipeline]
for v in self.pipeline_views]
self.signature = md5_text(*pipe_ids).hexdigest()

def get_pipeline_views(self):
Expand Down Expand Up @@ -201,10 +201,10 @@ def current_step(self):
"""
step_index = self.state.step_index

if step_index == len(self.pipeline):
if step_index == len(self.pipeline_views):
return self.finish_pipeline()

step = self.pipeline[step_index]
step = self.pipeline_views[step_index]

# support late binding steps
if isinstance(step, LambdaType):
Expand Down