Skip to content

fix(trace-view): web vital margins'#84858

Merged
Abdkhan14 merged 2 commits into
masterfrom
fix/trace-vital-spacing
Feb 10, 2025
Merged

fix(trace-view): web vital margins'#84858
Abdkhan14 merged 2 commits into
masterfrom
fix/trace-vital-spacing

Conversation

@doralchan

@doralchan doralchan commented Feb 10, 2025

Copy link
Copy Markdown
Contributor
  • Added padding below trace tags
  • Added conditional margin to web vitals

After:
W/O Web Vitals
Screenshot 2025-02-10 at 8 36 21 AM

W/ Web Vitals
Screenshot 2025-02-10 at 8 36 15 AM

Before:
Screenshot 2025-02-10 at 8 38 39 AM

@doralchan doralchan requested review from a team February 10, 2025 16:37
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 10, 2025

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this so quickly! Does this also fix the missing margin at the bottom of the page?

@Abdkhan14 Abdkhan14 merged commit 0a9719f into master Feb 10, 2025
@Abdkhan14 Abdkhan14 deleted the fix/trace-vital-spacing branch February 10, 2025 18:00
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants