Skip to content

fix(symbolication): Temporarily disable Intel symbol source#85526

Merged
loewenheim merged 1 commit into
masterfrom
fix/disable-intel
Feb 20, 2025
Merged

fix(symbolication): Temporarily disable Intel symbol source#85526
loewenheim merged 1 commit into
masterfrom
fix/disable-intel

Conversation

@loewenheim

Copy link
Copy Markdown
Contributor

Right now Symbolicator is not able to successfully download from the Intel source because the source doesn't accept custom user agents. Until we are confident we can spoof Symbolicator's user agent without abusing the source, we are disabling it. See https://github.com/getsentry/team-ingest/issues/642.

@loewenheim loewenheim self-assigned this Feb 20, 2025
@loewenheim loewenheim requested a review from a team February 20, 2025 12:29
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 20, 2025

@Dav1dde Dav1dde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this does not mess with the symbol sources a user has selected in their settings?

@loewenheim

Copy link
Copy Markdown
Contributor Author

I assume this does not mess with the symbol sources a user has selected in their settings?

The relevant code is this:

# Add builtin sources last to ensure that custom sources have precedence
# over our defaults.
builtin_sources = project.get_option("sentry:builtin_symbol_sources")
for key, source in settings.SENTRY_BUILTIN_SOURCES.items():
if key not in builtin_sources:
continue

Effectively we compute the intersection of our builtin sources list and the project's selected builtin sources. That project setting is otherwise untouched.

@codecov

codecov Bot commented Feb 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #85526      +/-   ##
==========================================
- Coverage   87.91%   87.89%   -0.02%     
==========================================
  Files        9577     9574       -3     
  Lines      542838   543607     +769     
  Branches    20863    20863              
==========================================
+ Hits       477221   477804     +583     
- Misses      65277    65463     +186     
  Partials      340      340              

@loewenheim loewenheim merged commit fcc02a7 into master Feb 20, 2025
@loewenheim loewenheim deleted the fix/disable-intel branch February 20, 2025 15:21
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants