fix(symbolication): Temporarily disable Intel symbol source#85526
Merged
Conversation
tobias-wilfert
approved these changes
Feb 20, 2025
Dav1dde
approved these changes
Feb 20, 2025
Dav1dde
left a comment
Member
There was a problem hiding this comment.
I assume this does not mess with the symbol sources a user has selected in their settings?
Contributor
Author
The relevant code is this: sentry/src/sentry/lang/native/sources.py Lines 519 to 524 in f39d338 Effectively we compute the intersection of our builtin sources list and the project's selected builtin sources. That project setting is otherwise untouched. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #85526 +/- ##
==========================================
- Coverage 87.91% 87.89% -0.02%
==========================================
Files 9577 9574 -3
Lines 542838 543607 +769
Branches 20863 20863
==========================================
+ Hits 477221 477804 +583
- Misses 65277 65463 +186
Partials 340 340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Symbolicator is not able to successfully download from the Intel source because the source doesn't accept custom user agents. Until we are confident we can spoof Symbolicator's user agent without abusing the source, we are disabling it. See https://github.com/getsentry/team-ingest/issues/642.