ref(debugger-modal): Display specific sentry-cli copy for react-native#86192
Conversation
github-actions
Bot
added
the
Scope: Frontend
| !sourceResolutionResults.sdkName?.startsWith( | ||
| 'sentry.javascript.react-native' | ||
| ) | ||
| isReactNativeSDK({sdkName: sourceResolutionResults.sdkName}) |
There was a problem hiding this comment.
Hosting Publicly shall not be shown for react-native and since this is minor, I am already fixing it here in this PR
| @@ -673,15 +676,24 @@ function HasDebugIdChecklistItem({ | |||
| </p> | |||
| {defined(sourceMapsDocLinks.sentryCli) && ( | |||
There was a problem hiding this comment.
Can we also update the text above?
From
It seems you already uploaded artifacts with Debug IDs, however, this event doesn't contain any Debug IDs yet. Generally this means that you didn't deploy the same files you injected the Debug IDs into. For Sentry to be able to show your original source code, it is required that you deploy the exact same files that you uploaded to Sentry.
To
It seems you already uploaded artifacts with Debug IDs, however, this event doesn't contain any Debug IDs yet. Generally this means that your application doesn't include the same files you uploaded to Sentry. For Sentry to be able to show your original source code, it is required that you build the application with the exact same files that you uploaded to Sentry.
cc: @smeubank
| @@ -673,15 +676,24 @@ function HasDebugIdChecklistItem({ | |||
| </p> | |||
| {defined(sourceMapsDocLinks.sentryCli) && ( | |||
There was a problem hiding this comment.
From
If you are using a [bundlerPluginRepoLink:Sentry Plugin for your Bundler], the plugin needs to be active when building your production app. You cannot do two separate builds, for example, one for uploading to Sentry with the plugin being active and one for deploying without the plugin. The plugin needs to be active for every build.
To bundlerPluginRepoLink = https://docs.sentry.io/platforms/react-native/manual-setup/metro/
The [bundlerPluginRepoLink:Sentry Metro Plugin] needs to be active when building your production app. You cannot do two separate builds, for example, one for uploading to Sentry with the plugin being active and one for deploying without the plugin. The plugin needs to be active for every build.
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
Looks good. 🚀
Thank you for fixing the source maps debugger for RN.
priscilawebdev
deleted the
priscila/ref/debugger-modal/display-specific-copy-sentry-cli-react-native
branch
3 participants
No description provided.