🔧 chore(azure devops login): write test to ensure the redirect uri is absolute#86462
Merged
Conversation
cathteng
approved these changes
Mar 6, 2025
Comment on lines
+109
to
+112
| # Verify the redirect URI is correctly constructed with absolute_uri | ||
| assert req_params["redirect_uri"][0] == absolute_uri( | ||
| reverse("sentry-extension-setup", kwargs={"provider_id": "vsts_new"}) | ||
| ) |
Contributor
There was a problem hiding this comment.
this is the different part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test is a unit test for the fix for inc-1054 (#86063).
it ensures that the redirect uri for azure devops is indeed the absolute uri instead of the relative one. i verified the test fails before the fix is made.
closes: https://getsentry.atlassian.net/browse/API-3026