Skip to content

feat(explore): Save and get explore query endpoints#86578

Merged
edwardgou-sentry merged 5 commits into
masterfrom
egou/feat/save-and-get-explore-query-endpoints
Mar 14, 2025
Merged

feat(explore): Save and get explore query endpoints#86578
edwardgou-sentry merged 5 commits into
masterfrom
egou/feat/save-and-get-explore-query-endpoints

Conversation

@edwardgou-sentry
Copy link
Copy Markdown
Contributor

@edwardgou-sentry edwardgou-sentry commented Mar 7, 2025

Adds GET and POST /explore/saved/ endpoints for saving and fetching saved explore queries.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 15 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/explore/endpoints/bases.py 42.10% 11 Missing ⚠️
.../sentry/explore/endpoints/explore_saved_queries.py 96.15% 3 Missing ⚠️
src/sentry/explore/endpoints/serializers.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86578       +/-   ##
===========================================
+ Coverage   56.40%   87.75%   +31.34%     
===========================================
  Files        9815     9831       +16     
  Lines      555505   556515     +1010     
  Branches    21926    21926               
===========================================
+ Hits       313345   488374   +175029     
+ Misses     241729    67710   -174019     
  Partials      431      431               

@edwardgou-sentry edwardgou-sentry force-pushed the egou/feat/save-and-get-explore-query-endpoints branch from 1db71bd to aada4b9 Compare March 12, 2025 22:25
@getsentry getsentry deleted a comment from github-actions Bot Mar 12, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review March 13, 2025 01:49
@edwardgou-sentry edwardgou-sentry requested review from a team as code owners March 13, 2025 01:49
@edwardgou-sentry edwardgou-sentry requested a review from a team March 13, 2025 01:49
Copy link
Copy Markdown
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a sanity check and the tests are adequate 🚢

@edwardgou-sentry edwardgou-sentry merged commit da6cabc into master Mar 14, 2025
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/save-and-get-explore-query-endpoints branch March 14, 2025 14:25
@sentry
Copy link
Copy Markdown
Contributor

sentry Bot commented Mar 20, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: assert [455575989688...5759896887297] == [455575989688...5759896887298] pytest.runtest.protocol tests/sentry/explore/en... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants