chore(fe): Refactor AbstractIntegrationDetailedView to make FC conversions easier#86656
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
leeandher
force-pushed
the
leander/ref-abstractintegrationdetailedview
branch
from
f79b43a to
706d826
Compare
This was referenced Mar 10, 2025
scttcper
reviewed
Mar 10, 2025
scttcper
reviewed
Mar 10, 2025
scttcper
approved these changes
Mar 10, 2025
leeandher
added a commit
that referenced
this pull request
Mar 10, 2025
Requires #86656 Not making any visual changes even though they would probably be welcome. For example, we still render tabs even though docs integrations only have one, so it's not really necessary.
leeandher
added a commit
that referenced
this pull request
Mar 12, 2025
Requires #86656 Tests are passing and an inspection of the page doesn't seem to have any issues. Requires that other PR because I pulled out a lot of the components that the abstract class renders to make conversions a bit easier, and to ensure the children still all render the same components (but without inheritance).
leeandher
added a commit
that referenced
this pull request
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
sentry/views/settings/organizationIntegrations/abstractIntegrationDetailedView.tsx: