fix: Add file path filters to Electron symbol source#86678
Merged
Conversation
This gates downloads from the public Electron symbol source behind a file path filter. This means that only downloads for modules with a debug file or code file matching one of these globs will even be attempted. This is to reduce the number of requests we make to the Electron symbol source that definitely will not succeed. The list of glob patterns we allow has been determined by examining Symbolicator log entries for successful downloads from the source. As such, it is always possible that there is a file on the source which is not covered by any of these patterns and which we just haven't seen in all the logs we examined.
github-actions
Bot
added
the
Scope: Backend
tobias-wilfert
approved these changes
Mar 11, 2025
loewenheim
added a commit
that referenced
this pull request
Mar 12, 2025
Fixup of #86678. The field for debug file paths is called `path_patterns`, not `file_paths`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gates downloads from the public Electron symbol source behind a file path filter. This means that only downloads for modules with a debug file or code file matching one of these globs will even be attempted.
This is to reduce the number of requests we make to the Electron symbol source that definitely will not succeed. The list of glob patterns we allow has been determined by examining Symbolicator log entries for successful downloads from the source. As such, it is always possible that there is a file on the source which is not covered by any of these patterns and which we just haven't seen in all the logs we examined.